Skip to content

Fix for gh-2121 #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 15, 2025
Merged

Fix for gh-2121 #2122

merged 3 commits into from
Jul 15, 2025

Conversation

ndgrigorian
Copy link
Collaborator

This PR proposes a fix for gh-2121, which is caused by underlying memory of a boolean array not necessarily representing only 0s and 1s, in particular when it is a view from a non-boolean array

This PR adds a path to astype that guarantees astype(a, "?") will give an output array of only 0 and 1

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian
fix gh-2121
f791949 
underlying memory of a boolean array may not be 0 and 1 when a boolean view is made from a non-boolean array, leading to unexpected results when copying element-wise, especially in astype

use a special path for boolean inputs to astype to make sure output is 0 and 1
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2025

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_58 ran successfully.
Passed: 1116
Failed: 5
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Jul 9, 2025 •
edited
Loading

Coverage Status

coverage: 85.887% (-0.003%) from 85.89%
when pulling 8e952d1 on resolve-gh-2121
into e2789db on master.

@ndgrigorian ndgrigorian marked this pull request as ready for review July 10, 2025 03:27
antonwolfy
antonwolfy reviewed Jul 10, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_59 ran successfully.
Passed: 1114
Failed: 7
Skipped: 119

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_60 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@ndgrigorian ndgrigorian requested a review from antonwolfy July 14, 2025 23:11
antonwolfy
antonwolfy approved these changes Jul 15, 2025
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian, LGTM!

@ndgrigorian ndgrigorian merged commit ab73617 into master Jul 15, 2025
79 of 98 checks passed
@ndgrigorian ndgrigorian deleted the resolve-gh-2121 branch July 15, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndgrigorian @coveralls @antonwolfy